Skip to content

fix #198: connected/disconnected events cannot dispatch to nested component #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2018
Merged

fix #198: connected/disconnected events cannot dispatch to nested component #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f4e026
fix #198: connected/disconnected events cannot dispatch to nested com…
liming Feb 21, 2018
6f766e4
fix #198: commit the coverage files
liming Feb 21, 2018
d488960
fix #198: add test cases
liming Feb 22, 2018
d5098d7
Merge remote-tracking branch 'upstream/master'
liming Feb 22, 2018
41a4531
fix #198: update basichtml to fix the test case
liming Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cjs/objects/Updates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,12 +474,12 @@ function observe() {
const dispatchTarget = (node, event) => {
if (components.has(node)) {
node.dispatchEvent(event);
} else {
const children = node.children;
const length = children.length;
for (let i = 0; i < length; i++) {
dispatchTarget(children[i], event);
}
}

const children = node.children;
const length = children.length;
for (let i = 0; i < length; i++) {
dispatchTarget(children[i], event);
}
}

Expand Down
2 changes: 1 addition & 1 deletion coverage/coverage.json
View file
Open in desktop

Large diffs are not rendered by default.

444 changes: 222 additions & 222 deletions coverage/lcov-report/hyperHTML/index.c.js.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion coverage/lcov-report/hyperHTML/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 07 2018 19:56:02 GMT+0100 (CET)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Feb 22 2018 22:26:06 GMT+1100 (AEDT)
</div>
</div>
<script src="../prettify.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Feb 07 2018 19:56:02 GMT+0100 (CET)
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Feb 22 2018 22:26:06 GMT+1100 (AEDT)
</div>
</div>
<script src="prettify.js"></script>
Expand Down
Loading