Skip to content

Fix case sensitivity of folder attribute parsing (\NoSelect, \NoInferiors) #469 #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

smajti1
Copy link
Contributor

@smajti1 smajti1 commented Apr 7, 2025

It should fix #469
Base on https://datatracker.ietf.org/doc/html/rfc3501#section-7.2.2 i also add check for \Noinferiors attribute

I have yet considered changing this function, to some thing like this:

protected function parseAttributes($attributes): void
{
	$normalized_attributes = array_map('strtolower', $attributes);

	$this->no_inferiors = in_array('\noinferiors', $normalized_attributes, true);
	$this->no_select = in_array('\noselect', $normalized_attributes, true);
	$this->marked = in_array('\marked', $normalized_attributes, true);
	$this->referral = in_array('\referral', $normalized_attributes, true);
	$this->has_children = in_array('\haschildren', $normalized_attributes, true);
}

@Webklex
Copy link
Owner

Webklex commented Apr 25, 2025

Hi @smajti1,
many thanks for your pull request and your patience <3

Best regards & happy coding,

@Webklex Webklex merged commit fb10c94 into Webklex:master Apr 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case sensitive \NoSelect flag check doesn't work for Gmail
2 participants