Fix Date parsing on non-standard format from Aqua Mail #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lm-cmxkonzepte
force-pushed
the
fix-aqua-mail-date
branch
from
9c4fef6 to
e0ce641
Compare
|
Hi @lm-cmxkonzepte, Best regards & happy coding, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #574. I only really changed the detection RegEx added for #198 to make the part after the slash optional. The actual parsing didn't need to be modified.
I added the new Format to the DateTemplateTest and to the table in the DocBlock for
Header::parseDate(). Let me know if anything is still missing!