-
Notifications
You must be signed in to change notification settings - Fork 303
Convert build procedure to use wp-scripts #65
Conversation
mkaz
commented
Mar 20, 2019
- Simplifies the build procedure to use wp-scripts setup
- Removes .babelrc and webpack.config.js to use standard configs from wp-scripts
- Adjusts code to live where wp-scripts expects it to be
|
Is this the new recommend best practice for block development? If so, a lot of documentation has to be updated. |
ntwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
❤️ the simplicity of it! |
Documentation inside Gutenberg has been already updated. We should post in make.wordpress.org/core with more details next week. All those changes introduced should make everything easier, but it's perfectly fine to use the old workflow. @mkaz, I noticed that each block has Thanks for starting this PR. I really like how this integrates. Finally, we can also enable linting for JS files and fix some issues like unused variables which I could quickly notice, e.g. https://github.com/WordPress/gutenberg-examples/blob/master/05-recipe-card-esnext/block.js#L1 - |
Co-Authored-By: mkaz <[email protected]>
|
@gziolo Good catch, I missed the .gitignore. Should we exclude the built file or not?
I really don't have much preference. |
|
https://github.com/WordPress/gutenberg-examples#installation this says you can copy and run. I'm inclined to keep those build files and remove |