Do not retry /renewjob on 404 #3828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
force-pushed
the
users/ericsciple/25-04-retry
branch
from
d0b9217 to
b6afcae
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the renew job API call to prevent retry attempts when a 404 error is encountered. The changes include adding a new lambda parameter to filter out TaskOrchestrationJobNotFoundException during the retry process.
- Prevent retry on 404 errors (TaskOrchestrationJobNotFoundException)
- Update the retry logic for the renew job API call
Comments suppressed due to low confidence (1)
src/Runner.Common/RunServer.cs:98
- Ensure that there are unit tests in place to verify that renew job calls are not retried when a TaskOrchestrationJobNotFoundException (HTTP 404) is encountered.
shouldRetry: ex =>
TingluoHuang
approved these changes
Apr 30, 2025
marko-k0
pushed a commit
to dfinity/runner
that referenced
this pull request
May 13, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.