-
Notifications
You must be signed in to change notification settings - Fork 664
Change missing cache directory error to warning #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change missing cache directory error to warning #1182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the error handling behavior when cache directories don't exist during the cache save operation. Instead of throwing an error that would fail the workflow, the action now logs a warning and continues execution.
- Replaces error throwing with warning logging when cache directories are missing
- Adds early return to prevent further cache operations when directories don't exist
- Improves developer experience by avoiding unnecessary workflow failures
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0. Release notes *Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).* > v6.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164) > > Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Enhancements: > > * Add support for `pip-version` by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129) > * Enhance reading from .python-version by [`@krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787) > * Add version parsing from Pipfile by [`@aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067) > > ### Bug fixes: > > * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183) > * Change missing cache directory error to warning by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182) > * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122) > * Include python version in PyPy python-version output by [`@cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110) > * Update docs: clarification on pip authentication with setup-python by [`@priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156) > > ### Dependency updates: > > * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843) > * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163) > * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181) > * Upgrade `@actions/tool-cache` from 2.0.1 to 2.0.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095) > > New Contributors > ---------------- > > * [`@krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787) > * [`@cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110) > * [`@aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067) > > **Full Changelog**: <actions/setup-python@v5...v6.0.0> Commits * [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164)) * [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w... * [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables... * [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181)) * [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182)) * [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn... * [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163)) * [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843)) * [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067)) * [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156)) * Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0. Release notes *Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).* > v6.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164) > > Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Enhancements: > > * Add support for `pip-version` by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129) > * Enhance reading from .python-version by [`@krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787) > * Add version parsing from Pipfile by [`@aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067) > > ### Bug fixes: > > * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183) > * Change missing cache directory error to warning by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182) > * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122) > * Include python version in PyPy python-version output by [`@cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110) > * Update docs: clarification on pip authentication with setup-python by [`@priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156) > > ### Dependency updates: > > * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843) > * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163) > * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181) > * Upgrade `@actions/tool-cache` from 2.0.1 to 2.0.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095) > > New Contributors > ---------------- > > * [`@krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787) > * [`@cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110) > * [`@aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067) > > **Full Changelog**: <actions/setup-python@v5...v6.0.0> Commits * [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164)) * [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w... * [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables... * [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181)) * [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182)) * [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn... * [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163)) * [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843)) * [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067)) * [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156)) * Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Description:
This PR updates the cache lookup logic to log a warning instead of throwing an error when a cache folder path is not found on disk.
Previously: action failed with Error: Cache folder path ... doesn't exist.
Now: action logs a warning via core.warning() and continues execution.
Motivation: In many cases, missing cache simply means there are no dependencies to cache, which should not fail the workflow.
This improves developer experience by preventing unnecessary workflow failures while still surfacing useful diagnostic information.
Related issue:
#436