Skip to content

Conversation

@SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented May 11, 2025

per guidelines and to make release more accessible without need for npm access.

@SergeAstapov
Copy link
Contributor Author

@gilest @RobbieTheWagner @jelhan @MelSumner could you add NPM_TOKEN secret to repository per https://github.com/embroider-build/create-release-plan-setup?tab=readme-ov-file#create-a-npm_token as I don't have access to package on npm.

@gilest
Copy link
Collaborator

gilest commented May 12, 2025

Thanks for taking this on @SergeAstapov

Have added an NPM_TOKEN which will work for 90 days. Not sure I'm the best person to do so, since I'm not an adopted-ember-addons org member. But it could always be replaced 🤷🏻

@SergeAstapov SergeAstapov merged commit 6397595 into master May 12, 2025
18 checks passed
@SergeAstapov SergeAstapov deleted the release-plan branch May 12, 2025 00:56
@github-actions github-actions bot mentioned this pull request May 12, 2025
@SergeAstapov
Copy link
Contributor Author

@gilest looks like it didn't work due to error

npm error 403 403 Forbidden - PUT https://registry.npmjs.org/ember-file-upload - Two-factor authentication is required to publish this package but an automation token was specified
npm error 403 In most cases, you or one of your dependencies are requesting
npm error 403 a package version that is forbidden by your security policy, or
npm error 403 on a server you do not have access to.

@gilest
Copy link
Collaborator

gilest commented May 12, 2025

Oh yes I see why, this was mentioned in the release-plan readme. Have updated the policy:

image

Please re-run the publish action, it should work now

@SergeAstapov
Copy link
Contributor Author

thank you @gilest ! v9.4.1 is out and available on npm https://www.npmjs.com/package/ember-file-upload

@RobbieTheWagner
Copy link
Member

We probably should make the token valid for a really long time, instead of 90 days. I usually choose like 12/31/2082

@gilest
Copy link
Collaborator

gilest commented Jul 1, 2025

Good shout @RobbieTheWagner . I have replaced the NPM_TOKEN secret with one that expires in 2083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants