This repository was archived by the owner on Oct 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
This repository was archived by the owner on Oct 22, 2021. It is now read-only.
RangeError: Maximum call stack size exceeded #23
Copy link
Copy link
Open
Labels
Description
Angular version: 1.4.7
angular-bind-notifier version: 1.1.4 (also on 1.1.3 and master)
I'm currently optimizing a huge table with many nested ng-repeat
s which means the number of watchers grows exponentially with amount of data. Recently I changed all bindings to bind once, and used your cool little library to be able to refresh data in table and rebind one-time bindings when necessary (e.g. sorting).
Everything works fine unless the table is really huge (i.e. hundreds of rows), then I get this error:
RangeError: Maximum call stack size exceeded
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:20:46)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13)
at wrap (http://localhost:5000/static/js/vendors/angular/angular-bind-notifier.js:24:13) <span ng-bind=":refreshTable:data | niceNumber" class="ng-binding">
The table still contains several watchers per row, which I'm going to further optimize, so it's possible this issue won't appear when the watcher number will drop to 1-2 per row.