Fix build #500
Closed
Fix build #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrDupin Yes, I agree adding the new lib is not a good idea. However, until we fix that properly, I don't think the build should stay broken. That's the only reason for this MR. |
|
Yes, definitely. |
|
@lucasmoura #501 would fix the dependency issue. As for the error with the local path, there are 4 more in search.ipynb |
|
I fixed the other notebook errors in another PR, #503. |
|
Seems this MR is not necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is currently broken, that's because the fuzzywuzzy lib was not being installed during the build.
Also, there was a error message with a local path in the search notebook, which I think is a bad idea. Therefore, I removed it.