Skip to content

Conversation

@Amaras
Copy link
Member

@Amaras Amaras commented Dec 5, 2021

This is the PR to close #972.

For now, I have implemented compilation with .class files.
We might want to use .jar files instead, but they require a manifest file.

It it also possible since Java 11 to simply run a single file, so a copier could be enough (assuming Java 11+).


@Amaras Amaras mentioned this pull request Dec 8, 2021
@Amaras Amaras added the SCons For SCons-related matters label Dec 19, 2021
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta be honest, I don't know Java super well, but I trust this

@Amaras
Copy link
Member Author

Amaras commented Dec 21, 2021

Alright, I guess I will merge this PR, it has been open long enough for people to criticize, and no disagreement came of it.
If you have any qualms, please open a PR in response to correct this.
The GH Actions run correctly, so I don't think there will be a problem with it, though (the changed filenames were fixed)

@Amaras Amaras merged commit 62f2a31 into algorithm-archivists:main Dec 21, 2021
@Amaras Amaras deleted the java_scons branch December 21, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCons For SCons-related matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java

2 participants