Dev-16: adding test case and ci integeration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bnlb merged 4 commits into algorithmiaio:master from jakemuntarsi:Dev-16

Jan 6, 2021

Contributor

jakemuntarsi commented Dec 25, 2020

No description provided.


          Dev-16, adding test case and ci integeration

c12641e

Contributor Author

jakemuntarsi commented Dec 29, 2020

@bnlb Could you please review this P

bnlb requested a review from a team

January 4, 2021 18:15

bnlb reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

test/algorithmiaTest.js Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

test/algorithmiaTest.js Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

test/testRunner.html Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

test/algorithmiaTest.js Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

test/testRunner.html Outdated Show resolved Hide resolved

bnlb commented Jan 4, 2021

Your .gitlab file looks good. Since this is a fork, the CI job isn't actually running in CI. I'd like to test that before merging this just to be safe. Can you create a branch with identical changes in the Algorithmia owned repo so I can see that the CI is passing as expected?


          Fixed minor review comments

31307ca

bnlb reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

bnlb reviewed

View reviewed changes

test/algorithmiaTest.js Show resolved Hide resolved


          Fixed review suggestions

72aacdd

bnlb reviewed

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved


          remove args fro npm test as it should be picked up from env variable

bb04fb0

bnlb approved these changes

View reviewed changes

bnlb left a comment

🌟

bnlb merged commit a1e031b into algorithmiaio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet