Algo-XXX proide a getDir() path for Data Directories #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeryx
changed the title
getDir() path [WIP]getDir() path
zeryx
changed the title
getDir() pathgetDir() path for Data Directories
zeryx
changed the title
getDir() path for Data Directories
zeryx
commented
Sep 17, 2021
|
|
||
| # Get file from the data api | ||
| def getFile(self): | ||
| def getFile(self, as_path=False): |
Contributor
Author
There was a problem hiding this comment.
also added a default null flag to getFile so that we can actually skip the .name weirdness and stop having dangling file handles 🎉
lemonez
reviewed
Sep 17, 2021
| local_file = file.getFile(as_path=True) | ||
| os.rename(local_file, correct_file_path) | ||
| return directory | ||
|
|
lemonez
reviewed
Sep 17, 2021
lemonez
reviewed
Sep 17, 2021
lemonez
approved these changes
Sep 17, 2021
kennydaniel
approved these changes
Sep 17, 2021
Contributor
kennydaniel
left a comment
kennydaniel
left a comment
There was a problem hiding this comment.
I kicked CI and it passed.
Re: as_path: I thought we had figured out a way to make all DataFiles a file-like object in python? Either way looks fine but not sure why that was needed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple customers and users have complained over the lack of support regarding downloading an entire data directory at once; preserving filenames and internal files. This PR adds a method to the data directory called
getDir(); this provides a temporary file in the users scratch space that preserves the heirarchy and datafiles + correct names of all files contained within.This PR has not added this functionality to the LocalDirectory system; and has been tested to function with S3 buckets