Dev 325 #116
Merged
Dev 325 #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved the ability to collect insights before sending, now the every time the user invokes the collectInsights method, it will also send. This prevents any State issues with the algorithm.
zeryx
reviewed
Nov 9, 2021
Contributor
zeryx
left a comment
zeryx
left a comment
There was a problem hiding this comment.
This is a little complex of a workflow enhancement, I see that this now should enable support for non-marketplace interfaces; but is there a suite of tests I can perform with the CLI itself (as a smoketest) outside of just the test harness created here?
zeryx
reviewed
Nov 22, 2021
Algorithmia/__main__.py
Outdated
|
|
||
| else: | ||
| if APIaddress == "" or not APIaddress.startswith("https://api."): | ||
| APIaddress = "https://api.algorithmia.com" |
Contributor
There was a problem hiding this comment.
This should fail with an error, not soft-recover IMO
| def client(api_key=None, api_address=None, ca_cert=None): | ||
| return Client(api_key, api_address, ca_cert) | ||
| def client(api_key=None, api_address=None, ca_cert=None, bearer_token=None): | ||
| return Client(api_key, api_address, ca_cert, bearer_token) |
Contributor
There was a problem hiding this comment.
What's the documented use for this bearer token?
added 2 commits
November 23, 2021 10:21
zeryx
approved these changes
Nov 26, 2021
Contributor
zeryx
left a comment
zeryx
left a comment
There was a problem hiding this comment.
Looks good to me, approving 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.