-
Notifications
You must be signed in to change notification settings - Fork 348
Add missing CHANGELOG entries for public JS API #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 14a81d6 |
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
20a0559 to
16689f2
Compare
16689f2 to
e253dbc
Compare
Co-authored-by: seaemsi <[email protected]>
Co-authored-by: seaemsi <[email protected]>
Co-authored-by: seaemsi <[email protected]>
e253dbc to
14a81d6
Compare
Member
Author
|
@seaemsi I've updated the changelog with all your suggestions. |
seaemsi
approved these changes
Sep 26, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing CHANGELOG entries for the PRs that were merged on
public-js-apiand provide public features.Each commit adds its own entry for easier review:
isSupportedtoall.mjs#5250onErrorcallback (AddonErrortocreateAll#5252 and AddonErrortoinitAll#5276)Of the other PRs in the list:
checkSupportmadestatic#5336 will be documented in the Frontend Docs when describing the base class, so thought we'd just link to the Frontend Docs rather than have a specific entry$moduleto$rootacross the codebase #5337, Encapsulate check for components support in method #5328, ChangeonErrortests to testconsole.lognot called #5306 are internal changesCloses #5321