-
Notifications
You must be signed in to change notification settings - Fork 348
Fix text within the inverse Service navigation variant not appearing in white #6047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 3c38481 |
Stylesheets changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
index 33adab20b..8324f0916 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
@@ -5885,6 +5885,7 @@ screen and (forced-colors:active) {
.govuk-template--rebranded .govuk-service-navigation--inverse {
border-bottom: none;
+ color: #fff;
background-color: #1d70b8
}
@@ -5918,7 +5919,7 @@ screen and (forced-colors:active) {
}
.govuk-template--rebranded .govuk-service-navigation--inverse .govuk-service-navigation__toggle:not(:focus) {
- color: #fff
+ color: currentcolor
}
.govuk-skip-link {
Action run for 3c38481 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/service-navigation/_index.scss b/packages/govuk-frontend/dist/govuk/components/service-navigation/_index.scss
index 110af2887..a487a4c85 100644
--- a/packages/govuk-frontend/dist/govuk/components/service-navigation/_index.scss
+++ b/packages/govuk-frontend/dist/govuk/components/service-navigation/_index.scss
@@ -214,6 +214,11 @@
@include _govuk-rebrand {
// Remove bottom border to add width-container ones
border-bottom: none;
+
+ // Set colour here so non-link text (service name, slot content) can
+ // use it too.
+ color: govuk-colour("white");
+
background-color: $govuk-brand-colour;
.govuk-width-container {
@@ -240,7 +245,7 @@
// Override mobile menu toggle colour when not focused
.govuk-service-navigation__toggle:not(:focus) {
- color: govuk-colour("white");
+ color: currentcolor;
}
}
}
Action run for 3c38481 |
owenatgov
approved these changes
Jun 27, 2025
Contributor
owenatgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
36degrees
reviewed
Jul 8, 2025
Co-authored-by: Oliver Byford <[email protected]>
910421f to
3c38481
Compare
Member
Author
|
There's a bunch of changes in Percy, presumably because of the changes to visual regression tests on main. I've marked the changes as approved. |
Merged
domoscargin
pushed a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6045.
Changes
coloracross the entire inverse Service navigation, so that non-link content (like service name or slotted content) also has colours inverted.colordefinitions to inherit the above.