Use brand palette through govuk-colour
#6326
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
romaricpascal
changed the title
govuk-colour
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
📋 StatsNo changes to any distributed file sizes! Action run for 5822b9b |
romaricpascal
changed the title
govuk-colourgovuk-colour
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
from
c9c156f to
31fcaff
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
from
42b7374 to
2fe49c2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
from
2fe49c2 to
ff2d069
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
romaricpascal
changed the title
govuk-colourgovuk-colour
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
|
Warning The Percy visual changes STILL NEED REVIEW Percy had some kind of blip and didn't detect changes. We then pushed again, and Percy now doesn't detect any difference between the current snapshots and the ones it approved because it didn't detect the changes. So now it's auto-approved the snapshots, despite correctly identifying that they differ from the base. Manual review needed! |
|
In the interests of avoiding a massive PR, I wonder if we could explore splitting this one up somehow. If we have no internal uses of Similarly, maybe split da935c5 and ebb1b12 into their own "adding the palette" PR and then the rest as a sort "using the new palette" PR? I can't remember exactly how interconnected each commit was, but it'd be nice to have smaller PRs. |
|
@romaricpascal I checked this page with all components and it looks ok! |
|
Dreamy! Cheers @mia-allers-gds. Once we've added a CHANGELOG we can merge it 😊 |
owenatgov
force-pushed
the
govuk-colour-for-brand
branch
from
8dd36e1 to
2de694d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
It was deprecated and will not be in v6.0 Co-authored-by: domoscargin <[email protected]> Co-authored-by: Owen Jones <[email protected]>
Add a separate palette for the brand colours, including all tints and shades. The palette is marked as private to encourage access through `govuk-colour` and not to modify it. Tests check that the right variants are present for each colour, so we don't mistakenly remove a variant. Co-authored-by: domoscargin <[email protected]> Co-authored-by: Owen Jones <[email protected]>
Includes looking up a fallback colour for colours that don't exist in the brand palette (like `light-grey`). Co-authored-by: domoscargin <[email protected]> Co-authored-by: Owen Jones <[email protected]>
Offer the corresponding replacement in the warning Co-authored-by: domoscargin <[email protected]> Co-authored-by: Owen Jones <[email protected]>
Co-authored-by: domoscargin <[email protected]> Co-authored-by: Owen Jones <[email protected]>
Co-authored-by: domoscargin <[email protected]> Co-authored-by: Owen Jones <[email protected]>
The palette is no longer used
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
from
2de694d to
38dcab4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
owenatgov
left a comment
owenatgov
left a comment
There was a problem hiding this comment.
Everything's looking good.
The only thing this is missing is the heading on removing the legacy param from the release notes doc (internal), since this PR also does that. If we can amend the lasty commit to add that then I think we're good.
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
from
38dcab4 to
1f8d1ef
Compare
govuk-design-system-ci
had a problem deploying
to
govuk-frontend-pr-6326
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
from
1f8d1ef to
5822b9b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6326
owenatgov
left a comment
owenatgov
left a comment
There was a problem hiding this comment.
Let's get it rolling baybeeeee
Adds the brand colours in a private
$_govuk-palettevariable and updatesgovuk-colourto allow access to the brand colours through the use of their$colourname and$variantname in the palette.Current
govuk-colourcall using only one parameter are automatically translated:$colourexists in the brand palette , return theprimaryvariant$colourdoes not exist in the brand palette, return an equivalent colour from the paletteThoughts
The new palette has been made private to discourage people from editing or overriding it, so it remains a source of truth for the colours provided by GOV.UK Frontend.
Fixes #6327