Deactivate govuk-tint and govuk-shade functions
#6341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6341
📋 StatsNo changes to any distributed file sizes! Action run for 7153d21 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
2 tasks
owenatgov
changed the title
govuk-tint and govuk-shade functions
owenatgov
force-pushed
the
deactivate-tint-and-shade
branch
from
7782a38 to
5d6f0dd
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6341
owenatgov
force-pushed
the
govuk-colour-for-brand
branch
from
8dd36e1 to
2de694d
Compare
3 tasks
romaricpascal
force-pushed
the
govuk-colour-for-brand
branch
3 times, most recently
from
1f8d1ef to
5822b9b
Compare
owenatgov
force-pushed
the
deactivate-tint-and-shade
branch
from
5d6f0dd to
c9a8e78
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6341
…o them Co-Authored-By: domoscargin <[email protected]>
owenatgov
force-pushed
the
deactivate-tint-and-shade
branch
from
c9a8e78 to
700ac41
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6341
Co-Authored-By: domoscargin <[email protected]>
Co-Authored-By: domoscargin <[email protected]>
owenatgov
force-pushed
the
deactivate-tint-and-shade
branch
from
700ac41 to
26bc8cc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6341
domoscargin
reviewed
Oct 20, 2025
domoscargin
approved these changes
Oct 20, 2025
Contributor
domoscargin
left a comment
domoscargin
left a comment
There was a problem hiding this comment.
Looks grand, just a small markdown typo to fix
owenatgov
force-pushed
the
deactivate-tint-and-shade
branch
from
26bc8cc to
7153d21
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-6341
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Makes
govuk-tintandgovuk-shadeinoperable. They now only return the colour passed to them and output a warning to the user advising them not to use either function.This PR also removes the one instance of
govuk-shadefrom service navigation.Resolves #6331
Notes
We haven't removed the numerous isntances of tint and shade in buttons, tags and file upload because they're covered in other PRs. Once the main colour system change PR is ready, we can merge all them and this one. This is also why the deprecation warning tests are failing.
I'm a little concered about the fact that with the change to the service nav colour, we're decoupling it from the applied link colour (
$govuk-link-colour). The squad are talking about if there's a need for a new applied colour for links on the tint 95% blue background. Relates to #6302