-
Notifications
You must be signed in to change notification settings - Fork 348
Remove --govuk-frontend-breakpoint CSS properties
#6385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d125e1b to
973a54e
Compare
Stylesheets changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
index a44f66ab5..f4978c50a 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
@@ -3,11 +3,8 @@
:root {
--govuk-frontend-version: "development";
--govuk-breakpoint-mobile: 20rem;
- --govuk-frontend-breakpoint-mobile: var(--govuk-breakpoint-mobile);
--govuk-breakpoint-tablet: 40.0625rem;
- --govuk-frontend-breakpoint-tablet: var(--govuk-breakpoint-tablet);
- --govuk-breakpoint-desktop: 48.0625rem;
- --govuk-frontend-breakpoint-desktop: var(--govuk-breakpoint-desktop)
+ --govuk-breakpoint-desktop: 48.0625rem
}
.govuk-link {
Action run for 352eeac |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/core/_govuk-frontend-properties.scss b/packages/govuk-frontend/dist/govuk/core/_govuk-frontend-properties.scss
index 6b9136d55..cd5e60fa0 100644
--- a/packages/govuk-frontend/dist/govuk/core/_govuk-frontend-properties.scss
+++ b/packages/govuk-frontend/dist/govuk/core/_govuk-frontend-properties.scss
@@ -6,9 +6,6 @@
// CSS custom property for each breakpoint
@each $name, $value in $govuk-breakpoints {
--govuk-breakpoint-#{$name}: #{govuk-px-to-rem($value)};
-
- // Deprecated, use `--govuk-breakpoint-[name]` instead
- --govuk-frontend-breakpoint-#{$name}: var(--govuk-breakpoint-#{$name});
}
}
Action run for 352eeac |
📋 StatsFile sizes
No changes to module sizes. Action run for 352eeac |
owenatgov
approved these changes
Oct 31, 2025
Contributor
owenatgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks grand. Changelog review next
seaemsi
reviewed
Nov 3, 2025
These were renamed to begin --govuk-breakpoint in 5.11.0 and the old names deprecated. Co-authored-by: seaemsi <[email protected]>
973a54e to
352eeac
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties were renamed to begin with
--govuk-breakpointin 5.11.0.Closes #6022.