Skip to content

Conversation

@querkmachine
Copy link
Member

The use of the all.scss file and _all.scss partials was deprecated in GOV.UK Frontend 5.8.0. These have been replaced by Sass standard index files.

Closes #4989.

Changes

  • Removed root all.scss file and _all.scss partials.
  • Removed tests checking for deprecation warnings when importing an all file.
  • Updated build task that was using the root all file.
  • Updated Sass CI test that was using the root all partial.
  • Updated README example that demonstrated importing the root all file.

@querkmachine querkmachine self-assigned this Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/all.scss b/packages/govuk-frontend/dist/govuk/all.scss
deleted file mode 100644
index b29cb4977..000000000
--- a/packages/govuk-frontend/dist/govuk/all.scss
+++ /dev/null
@@ -1,9 +0,0 @@
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/all' is deprecated. Update your import statement to import 'govuk/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/components/_all.scss b/packages/govuk-frontend/dist/govuk/components/_all.scss
deleted file mode 100644
index b8fd480b8..000000000
--- a/packages/govuk-frontend/dist/govuk/components/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/components/all' is deprecated. Update your import statement to import 'govuk/components/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/core/_all.scss b/packages/govuk-frontend/dist/govuk/core/_all.scss
deleted file mode 100644
index 919b9ac03..000000000
--- a/packages/govuk-frontend/dist/govuk/core/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/core/all' is deprecated. Update your import statement to import 'govuk/core/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/helpers/_all.scss b/packages/govuk-frontend/dist/govuk/helpers/_all.scss
deleted file mode 100644
index b6850afda..000000000
--- a/packages/govuk-frontend/dist/govuk/helpers/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/helpers/all' is deprecated. Update your import statement to import 'govuk/helpers/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/objects/_all.scss b/packages/govuk-frontend/dist/govuk/objects/_all.scss
deleted file mode 100644
index a393b2724..000000000
--- a/packages/govuk-frontend/dist/govuk/objects/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/objects/all' is deprecated. Update your import statement to import 'govuk/objects/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/overrides/_all.scss b/packages/govuk-frontend/dist/govuk/overrides/_all.scss
deleted file mode 100644
index d28d0e7a9..000000000
--- a/packages/govuk-frontend/dist/govuk/overrides/_all.scss
+++ /dev/null
@@ -1,9 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/overrides/all' is deprecated. Update your import statement to import 'govuk/overrides/index'."
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/settings/_all.scss b/packages/govuk-frontend/dist/govuk/settings/_all.scss
deleted file mode 100644
index 7fc16e9b4..000000000
--- a/packages/govuk-frontend/dist/govuk/settings/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/settings/all' is deprecated. Update your import statement to import 'govuk/settings/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/tools/_all.scss b/packages/govuk-frontend/dist/govuk/tools/_all.scss
deleted file mode 100644
index 857712d6b..000000000
--- a/packages/govuk-frontend/dist/govuk/tools/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/tools/all' is deprecated. Update your import statement to import 'govuk/tools/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/utilities/_all.scss b/packages/govuk-frontend/dist/govuk/utilities/_all.scss
deleted file mode 100644
index cc1da2ab0..000000000
--- a/packages/govuk-frontend/dist/govuk/utilities/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
-  "import-using-all",
-  "Importing using 'govuk/utilities/all' is deprecated. Update your import statement to import 'govuk/utilities/index'.",
-  $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */

Action run for 193b14b

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

📋 Stats

No changes to any distributed file sizes!


Action run for 193b14b

@querkmachine querkmachine changed the title Remove all Sass files Remove all.scss file and partials Nov 3, 2025
@querkmachine querkmachine marked this pull request as ready for review November 3, 2025 15:21
@querkmachine querkmachine requested a review from a team as a code owner November 3, 2025 15:21
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@querkmachine querkmachine force-pushed the remove-all.scss-files branch from 03cd1a2 to 193b14b Compare November 3, 2025 16:25
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-6412 November 3, 2025 16:25 Inactive
@querkmachine
Copy link
Member Author

@owenatgov Not sure if the review went weird but GitHub is asking for your approval before letting me merge it!

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Maybe a new changes thing? Whatever enjoy your second green tick ✅

@querkmachine querkmachine merged commit afc5ab3 into main Nov 3, 2025
45 checks passed
@querkmachine querkmachine deleted the remove-all.scss-files branch November 3, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove any all.scss files in favour of index.scss

5 participants