-
Notifications
You must be signed in to change notification settings - Fork 348
Remove all.scss file and partials
#6412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/all.scss b/packages/govuk-frontend/dist/govuk/all.scss
deleted file mode 100644
index b29cb4977..000000000
--- a/packages/govuk-frontend/dist/govuk/all.scss
+++ /dev/null
@@ -1,9 +0,0 @@
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/all' is deprecated. Update your import statement to import 'govuk/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/components/_all.scss b/packages/govuk-frontend/dist/govuk/components/_all.scss
deleted file mode 100644
index b8fd480b8..000000000
--- a/packages/govuk-frontend/dist/govuk/components/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/components/all' is deprecated. Update your import statement to import 'govuk/components/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/core/_all.scss b/packages/govuk-frontend/dist/govuk/core/_all.scss
deleted file mode 100644
index 919b9ac03..000000000
--- a/packages/govuk-frontend/dist/govuk/core/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/core/all' is deprecated. Update your import statement to import 'govuk/core/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/helpers/_all.scss b/packages/govuk-frontend/dist/govuk/helpers/_all.scss
deleted file mode 100644
index b6850afda..000000000
--- a/packages/govuk-frontend/dist/govuk/helpers/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/helpers/all' is deprecated. Update your import statement to import 'govuk/helpers/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/objects/_all.scss b/packages/govuk-frontend/dist/govuk/objects/_all.scss
deleted file mode 100644
index a393b2724..000000000
--- a/packages/govuk-frontend/dist/govuk/objects/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/objects/all' is deprecated. Update your import statement to import 'govuk/objects/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/overrides/_all.scss b/packages/govuk-frontend/dist/govuk/overrides/_all.scss
deleted file mode 100644
index d28d0e7a9..000000000
--- a/packages/govuk-frontend/dist/govuk/overrides/_all.scss
+++ /dev/null
@@ -1,9 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/overrides/all' is deprecated. Update your import statement to import 'govuk/overrides/index'."
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/settings/_all.scss b/packages/govuk-frontend/dist/govuk/settings/_all.scss
deleted file mode 100644
index 7fc16e9b4..000000000
--- a/packages/govuk-frontend/dist/govuk/settings/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/settings/all' is deprecated. Update your import statement to import 'govuk/settings/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/tools/_all.scss b/packages/govuk-frontend/dist/govuk/tools/_all.scss
deleted file mode 100644
index 857712d6b..000000000
--- a/packages/govuk-frontend/dist/govuk/tools/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/tools/all' is deprecated. Update your import statement to import 'govuk/tools/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
diff --git a/packages/govuk-frontend/dist/govuk/utilities/_all.scss b/packages/govuk-frontend/dist/govuk/utilities/_all.scss
deleted file mode 100644
index cc1da2ab0..000000000
--- a/packages/govuk-frontend/dist/govuk/utilities/_all.scss
+++ /dev/null
@@ -1,10 +0,0 @@
-@import "https://github.com/settings/warnings";
-@import "https://github.com/index";
-
-@include _warning(
- "import-using-all",
- "Importing using 'govuk/utilities/all' is deprecated. Update your import statement to import 'govuk/utilities/index'.",
- $silence-further-warnings: false
-);
-
-/*# sourceMappingURL=_all.scss.map */
Action run for 193b14b |
📋 StatsNo changes to any distributed file sizes! Action run for 193b14b |
owenatgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
03cd1a2 to
193b14b
Compare
|
@owenatgov Not sure if the review went weird but GitHub is asking for your approval before letting me merge it! |
owenatgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. Maybe a new changes thing? Whatever enjoy your second green tick ✅
The use of the
all.scssfile and_all.scsspartials was deprecated in GOV.UK Frontend 5.8.0. These have been replaced by Sass standardindexfiles.Closes #4989.
Changes
all.scssfile and_all.scsspartials.allfile.allfile.allpartial.allfile.