Skip to content

Add Criteo support to amp-ad - #2299

Merged
cramforce merged 1 commit into
ampproject:masterfrom
criteo-forks:master
Mar 2, 2016
Merged

Add Criteo support to amp-ad#2299
cramforce merged 1 commit into
ampproject:masterfrom
criteo-forks:master

Conversation

@nicolastruchi

Copy link
Copy Markdown
Contributor

add support to amp-ad for the Criteo type.

Intent to implement: #2296

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Comment thread ads/criteo.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to your own docs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@cramforce

Copy link
Copy Markdown
Member

This is good to go. Please rebase and push again. Thanks!

@nicolastruchi

Copy link
Copy Markdown
Contributor Author

I signed it!

Signed with Corporate CLA for the company: Criteo SA

cramforce added a commit that referenced this pull request Mar 2, 2016
Add Criteo support to amp-ad
@cramforce
cramforce merged commit d528074 into ampproject:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants