-
Notifications
You must be signed in to change notification settings - Fork 14
Google Analytics helper #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sinedied
merged 9 commits into
angular-starter-kit:feature/analytics
from
bursauxa:master
Jan 13, 2017
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
15531a4
Added analytics service in /helpers. This services supports basic pag…
bursauxa 324a620
Fixed some Yeoman and Typescript issues.
bursauxa 6832800
More Typescript magic because my window is better than their window.
bursauxa 555fe01
Added missing type import. Build should be all good now.
bursauxa d06d2f6
Added missing semicolon.
bursauxa 4b8be83
Made some changes according to code review from pull request.
bursauxa 71d0935
Made some changes according to code review from pull request.
bursauxa d4dc9cc
Merge branch 'master' of https://github.com/bursauxa/generator-angula…
bursauxa 5c84ec4
Moved analytics ID from Config to Environment.
bursauxa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Moved analytics ID from Config to Environment.
- Loading branch information
commit 5c84ec427850fed6e841a56dba1ed1f97266dc4b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logger not needed if it's not used, or maybe it could be used to log tracked events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, logging tracked events was the point. I must have lost it somewhere along the road ; will fix it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done earlier (with previous changes).