Fix dropdown auto close in mobile phones for angular ~1.4.7 #4643
Conversation
|
Please create a functional test that checks for this event handler being added, triggered, and removed. |
| @@ -23,6 +24,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position']) | |||
| this.close = function(dropdownScope) { | |||
| if (openScope === dropdownScope) { | |||
| openScope = null; | |||
| $document.unbind('touch', closeDropdown); | |||
There was a problem hiding this comment.
Nice job on remembering this - it's REALLY easy to forget to do.
There was a problem hiding this comment.
I close it because I realize that the thing that was wrong and nonfunctional were the $document.bind (mobilephone) in angular ~1.4.7 so my code does not fix anything... I am looking what is going on.
There was a problem hiding this comment.
The problems seems to happend only in elements with ng-click attribute and with ngTouch enabled
|
ngTouch rewrites ngClick and cause problems in dropdowns that are not auto close properly. comment angular-touch.js line 159 and 160 fix the problem. https://github.com/angular/angular.js/blob/master/src/ngTouch/directive/ngClick.js#L159 |
Auto close dropdowns when click was broken in mobile phones with angular ~1.4.7