-
Notifications
You must be signed in to change notification settings - Fork 189
Use applyAsync instead of apply, to avoid digest in progress issues #74
Conversation
|
Uhm how come this single line change can cause the Travis CI build to fail? or the build was failing to begin with? I hope the owner can come in and merge this PR. Otherwise we might just use @43081j 's #master |
|
+1, helped me. |
|
ui-codemirror declare a dependency on Angular |
|
Tried to update to However, tests still somehow fail, checking it out now. |
|
The failing tests seem to be checking that the CodeMirror constructor has been called with the defaults and the additional options. However, in the source, it seems we don't ever call the constructor with the defaults? so the tests fail because they just get the value and additional opts, from ui-codemirror.js#L29. |
|
Thank you guys for all of the work here. hey @douglasduteil, would you mind take a look at this? I think people here really want to get this PR merged and the issue fixed. |
|
I changed the tests to also use The remaining broken tests are due to the default options not being passed into the constructor (ever?). |
|
Hi there sorry for not being there for so long... |
|
Alright thanks a lot @43081j |
|
Good job everyone!! Yay :) I am glad that we finally got this done!! Cheers! |
There are quite a few cases where this
$applycall causes the usualdigest in progresserror (see #73).Using
$applyAsyncseems to solve the issue as we don't really care about changing it immediately, but rather on the next digest.