-
Notifications
You must be signed in to change notification settings - Fork 12k
Invalid i18n configuration: Locales 'ru' and 'en' cannot have the same subPath: ''. #29398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I personally used baseHref="" for i18n versions of my app that each will be deployed to the / of their own subdomain. I failed to get this to work with "subPath", is there a documented new way on how to have different languages on a different root paths? |
You can make separate angular.json files and rename them before build in your CI, but let's wait for the official response |
…te `subPaths` with inlined locales The i18n configuration validation was incorrectly flagging errors for identical `subPaths` when both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales. This commit fixes this issue by ensuring that the validation only checks for duplicate `subPaths` when the locales are inlined. Closes angular#29396 and closes angular#29398
…te `subPaths` with inlined locales The i18n configuration validation was incorrectly flagging errors for identical `subPaths` when both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales. This commit fixes this issue by ensuring that the validation only checks for duplicate `subPaths` when the locales are inlined. Closes angular#29396 and closes angular#29398
…te `subPaths` with inlined locales The i18n configuration validation was incorrectly flagging errors for identical `subPaths` when both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales. This commit fixes this issue by ensuring that the validation only checks for duplicate `subPaths` when the locales are inlined. Closes angular#29398
…te `subPaths` with inlined locales The i18n configuration validation was incorrectly flagging errors for identical `subPaths` when both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales. This commit fixes this issue by ensuring that the validation only checks for duplicate `subPaths` when the locales are inlined. Closes #29398 (cherry picked from commit 334ec0f)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Command
build
Is this a regression?
The previous version in which this bug was not present was
No response
Description
Hey.
With v19.1 it's not possible to build with this config:
How about moving non-unique subPath check inside build configuration, but not global?
This should fail:
This should not:
Minimal Reproduction
ng build
Exception or Error
Your Environment
Anything else relevant?
No response
The text was updated successfully, but these errors were encountered: