Skip to content

Remove copyright comments from vendor.bundle.js #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YagoLopez opened this issue Jul 10, 2017 · 3 comments
Closed

Remove copyright comments from vendor.bundle.js #6933

YagoLopez opened this issue Jul 10, 2017 · 3 comments

Comments

@YagoLopez
Copy link

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x ] feature request

Versions.

@angular/cli: 1.2.0
node: 6.10.0
os: win32 x64
@angular/common: 4.2.6
@angular/compiler: 4.2.6
@angular/core: 4.2.6
@angular/forms: 4.2.6
@angular/http: 4.2.6
@angular/platform-browser: 4.2.6
@angular/platform-browser-dynamic: 4.2.6
@angular/router: 4.2.6
@angular/cli: 1.2.0
@angular/compiler-cli: 4.2.6

Mention any other details that might be useful.

In my opinion after AOT compilation could be convenient to leave only one copyright note on "vendor.bunle.js" to reduce file size. Now you have a lot of comments repeated. See this example:

https://yagolopez.js.org/ng-dashboard/dist/vendor.bundle.js

@grizzm0
Copy link
Contributor

grizzm0 commented Jul 11, 2017

Already seems to be part of 1.3.0-beta.0.
See #4694

@YagoLopez
Copy link
Author

@grizzm0 Great! Thanks for the info. I had searched for this topic before opening the issue but found nothing. Excuse me.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants