Skip to content

feat(Tracking): remove deduped licenses #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2017
Merged

feat(Tracking): remove deduped licenses #4694

merged 1 commit into from
Jun 2, 2017

Conversation

sumitarora
Copy link
Contributor

clydin
clydin reviewed Feb 14, 2017
View reviewed changes
packages/@angular/cli/models/webpack-configs/common.ts Outdated
@@ -121,6 +122,9 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
excludeChunks: lazyChunks,
xhtml: true
}),
new LicenseWebpackPlugin({
pattern: /^(MIT|ISC|BSD.*)$/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all license types be included?

hansl
hansl reviewed Feb 14, 2017
View reviewed changes
packages/@angular/cli/models/webpack-configs/production.ts Outdated
@@ -74,7 +74,8 @@ export const getProdConfig = function (wco: WebpackConfigOptions) {
new webpack.optimize.UglifyJsPlugin(<any>{
mangle: { screw_ie8: true },
compress: { screw_ie8: true, warnings: buildOptions.verbose },
sourceMap: buildOptions.sourcemap
sourceMap: buildOptions.sourcemap,
comments: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are legal implications to this. Do we need to remove comments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified with legal and they said removing the comments from a build output is fine in our case. This LGTM (needs to fix errors on CI)

@sumitarora sumitarora force-pushed the feat-licenses2 branch 2 times, most recently from 6e8f98e to 757f669 Compare February 15, 2017 15:54
@sumitarora sumitarora force-pushed the feat-licenses2 branch 9 times, most recently from d069c55 to 1c16f12 Compare March 3, 2017 17:03
@filipesilva
Copy link
Contributor

@sumitarora can you rebase to see if there are still CI problems?

@sumitarora
Copy link
Contributor Author

@filipesilva There is issue with the license webpack plugin I have already created issue on its repo as well as did PR for it xz64/license-webpack-plugin#11 once it is released and updated we can merge the merge.

filipesilva
filipesilva suggested changes Mar 10, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for this? Otherwise we won't know if it breaks accidentally.

@clydin
Copy link
Member

clydin commented Mar 10, 2017 •
edited
Loading

Can this be made optional via a command/config option?
The actual act of distribution of the built app is generally with the end-user and their legal teams may have differing opinions on the topic.

@intellix intellix mentioned this pull request Mar 10, 2017
Closed
@sumitarora sumitarora force-pushed the feat-licenses2 branch 5 times, most recently from fd377a7 to 4a34e85 Compare March 13, 2017 16:05
@sumitarora sumitarora closed this Mar 24, 2017
@sumitarora sumitarora deleted the feat-licenses2 branch March 24, 2017 16:35
@sumitarora sumitarora restored the feat-licenses2 branch March 24, 2017 16:46
@sumitarora sumitarora reopened this Mar 24, 2017
@fknop
Copy link

fknop commented Apr 11, 2017 •
edited
Loading

Any news on this PR ? It looks like xz64/license-webpack-plugin#11 has been solved for a month.

What could eventually be made to help ?

@sumitarora sumitarora force-pushed the feat-licenses2 branch 2 times, most recently from 89d3ef6 to a2bee5c Compare May 16, 2017 23:36
@sumitarora sumitarora changed the title fix(Tracking): remove deduped licenses feat(Tracking): remove deduped licenses May 16, 2017
hansl
hansl suggested changes May 23, 2017
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. Mostly text.

docs/documentation/build.md Outdated
@@ -77,6 +77,8 @@ Flag | `--dev` | `--prod`
`--sourcemaps` | `true` | `false`
`--extract-css` | `false` | `true`

`--extract-licenses` (`-el`) Extract all licenses in a seprate file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: separate.

packages/@angular/cli/commands/build.ts Outdated
type: Boolean,
default: true,
aliases: ['el'],
description: 'Extract all licenses in a seprate file.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: separate.

packages/@angular/cli/commands/build.ts
{
name: 'extract-licenses',
type: Boolean,
default: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify in the description that this flag is only used in production builds (when --target=prod)? Seems like people might think it will affect dev builds as well.

packages/@angular/cli/models/webpack-configs/common.ts Outdated
@@ -6,7 +6,6 @@ import { WebpackConfigOptions } from '../webpack-config';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reverse this file please? It just adds to the noise of the history.

packages/@angular/cli/commands/build.ts Outdated
name: 'extract-licenses',
type: Boolean,
default: true,
aliases: ['el'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want a short hand for this option.

@sumitarora sumitarora force-pushed the feat-licenses2 branch 5 times, most recently from 2568ebd to 0ceb419 Compare May 24, 2017 00:16
hansl
hansl previously approved these changes May 24, 2017
View reviewed changes
hansl
hansl approved these changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@filipesilva filipesilva merged commit e72693a into angular:master Jun 2, 2017
@grizzm0 grizzm0 mentioned this pull request Jul 11, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin left review comments

@hansl hansl hansl approved these changes

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking: Deduping licenses
6 participants
@sumitarora @filipesilva @clydin @fknop @hansl @googlebot