-
Notifications
You must be signed in to change notification settings - Fork 12k
Fix for noImplicitAny: make them explicit any refs #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…licit type any. This is not allowed in the config of TypeScript compiler. Thus all these references must be made explicit any types.
…gular#1987) * fix(find-lazy-modules): Allow for any valid keys/value to be used and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes angular#1891, angular#1960. cc @filipesilva @ericjim @chalin - See similar angular#1972 * cleanup
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Indeed, I authored these changes. When I check the log, commit 71670ae clearly states the origin. |
Merges from Pull Requests do not always show the exact origins, I noticed in this particular project. However small the contribution may be, it is also possible that someone other than me, came up with the same fix in a possibly larger Pull Request. |
At any rate, the change is in, that's all the counts. |
* update awesome-typescript-loader and compiler-cli to accommodate changes in TS 2.0.0+
This PR seems out of date now with the latest changes. Also, we do not want to force I'm going to close this PR as most of its content is already in master. As for the CLA bot, it gets confused sometimes. I can still merge without its accord, so just comment that you agree with the terms and I will ignore it. Cheers! |
No problem, close it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Some references in packages/base-href-webpack-plugin.spec.ts have implicit type any.
This is not allowed in the config of TypeScript compiler.
Thus all these references must be made explicit any types.
Similarly to issue #1876, this time the build fails with:
This PR fixes the compilation errors.