Skip to content

fix(@schematics/angular): show warning when migrating ng-packagr JS configurations #22117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix(@schematics/angular): show warning when migrating ng-packagr JS configurations #22117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/schematics/angular/migrations/update-13/update-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import { join } from '@angular-devkit/core';
import { join, tags } from '@angular-devkit/core';
import { DirEntry, Rule } from '@angular-devkit/schematics';
import { JSONFile } from '../../utility/json-file';
import { allTargetOptions, getWorkspace } from '../../utility/workspace';
Expand Down Expand Up @@ -36,7 +36,7 @@ export default function (): Rule {
['lib', 'umdId'],
];

return async (tree) => {
return async (tree, context) => {
const workspace = await getWorkspace(tree);
const librariesTsConfig = new Set<string>();
const ngPackagrConfig = new Set<string>();
Expand All @@ -53,7 +53,14 @@ export default function (): Rule {
}

if (typeof options.project === 'string') {
ngPackagrConfig.add(options.project);
if (options.project.endsWith('.json')) {
ngPackagrConfig.add(options.project);
} else {
context.logger
.warn(tags.stripIndent`Expected a JSON configuration file but found "${options.project}".
You may need to adjust the configuration file to remove invalid options.
For more information, see the breaking changes section within the release notes: https://github.com/ng-packagr/ng-packagr/releases/tag/v13.0.0/.`);
}
}
}
}
Expand Down