Skip to content

fix(@angular-devkit/build-angular): support ESNext as target for JavaScript optimizations #22501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2022
Merged

fix(@angular-devkit/build-angular): support ESNext as target for JavaScript optimizations #22501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/angular_devkit/build_angular/src/webpack/plugins/javascript-optimizer-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,12 @@ export class JavaScriptOptimizerPlugin {
if (this.options.target) {
if (this.options.target <= ScriptTarget.ES5) {
target = 5;
} else if (this.options.target < ScriptTarget.ESNext) {
} else if (this.options.target === ScriptTarget.ESNext) {
target = 'next';
} else {
target = Number(
ScriptTarget[this.options.target].slice(2),
) as OptimizeRequestOptions['target'];
} else {
target = 2020;
}
}

Expand Down
7 changes: 4 additions & 3 deletions packages/angular_devkit/build_angular/src/webpack/plugins/javascript-optimizer-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export interface OptimizeRequestOptions {
/**
* Specifies the target ECMAScript version for the output code.
*/
target: 5 | 2015 | 2016 | 2017 | 2018 | 2019 | 2020;
target: 5 | 2015 | 2016 | 2017 | 2018 | 2019 | 2020 | 'next';
/**
* Controls whether esbuild should only use the WASM-variant instead of trying to
* use the native variant. Some platforms may not support the native-variant and
Expand Down Expand Up @@ -105,7 +105,8 @@ export default async function ({ asset, options }: OptimizeRequest) {
asset.name,
esbuildResult.code,
options.sourcemap,
options.target,
// Terser only supports up to ES2020.
options.target === 'next' ? 2020 : options.target,
options.advanced,
);

Expand Down Expand Up @@ -208,7 +209,7 @@ async function optimizeWithTerser(
name: string,
code: string,
sourcemaps: boolean | undefined,
target: OptimizeRequest['options']['target'],
target: Exclude<OptimizeRequest['options']['target'], 'next'>,
advanced: boolean | undefined,
): Promise<{ code: string; map?: object }> {
const result = await minify(
Expand Down