fix(@schematics/angular): align Karma project generation with unified unit-test builder #31651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
ng-new/karma-runner-new
branch
9 times, most recently
from
ea24c45 to
f88a895
Compare
… unit-test builder Updates the application and ng-new schematics to correctly configure Karma-based projects. - The test target in the generated angular.json now uses the `@angular/build:unit-test` builder. - The builder options are simplified to only include runner: 'karma', as other settings are now handled by the unified builder. - Corresponding schematic tests have been updated to reflect these changes.
clydin
force-pushed
the
ng-new/karma-runner-new
branch
from
f88a895 to
c2019d5
Compare
…ation This commit enhances the `config` schematic to provide better guidance and correctness when generating a Karma configuration file. Changes include: - The `addKarmaConfig` function now correctly handles projects using the `@angular/build:unit-test` builder. - When the `unit-test` builder is in use, the schematic checks the `runner` option in both the main `options` and all `configurations` of the `test` target. - Warnings are issued if the `runner` is not explicitly set to `karma` (defaulting to Vitest) or if it's set to a different runner, informing the user that the generated `karma.conf.js` might not be used. - Corresponding unit tests have been added to `packages/schematics/angular/config/index_spec.ts` to validate this new warning behavior and ensure correct interaction with the `unit-test` builder.
clydin
force-pushed
the
ng-new/karma-runner-new
branch
from
ac4b251 to
941c262
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 4, 2025
alan-agius4
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the application and ng-new schematics to correctly configure Karma-based projects.
@angular/build:unit-testbuilder.