fix(@angular/cli): Fixing duplicate lint errors #5288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
suggested changes
Mar 7, 2017
packages/@angular/cli/tasks/lint.ts
Outdated
| @@ -60,6 +60,9 @@ export default Task.extend({ | |||
| errors += result.failureCount; | |||
| results = results.concat(result.output.trim().concat('\n')); | |||
| }); | |||
| let allResults = results.split('\n'); | |||
| allResults = allResults.filter((item, index) => item.indexOf(item) === index); | |||
| results = allResults.toString(); | |||
There was a problem hiding this comment.
Shouldn't the new line character be re-inserted into the string? So instead of just calling toString use join('\n')
sumitarora
force-pushed
the
fix-duplicate-lint-errors
branch
from
ccbdac2 to
10ded6d
Compare
|
It seems #5224 covers this behaviour and some extras. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should Fix: #5259