-
Notifications
You must be signed in to change notification settings - Fork 12k
Allow partially overriding webpack config #7181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If a webpack.config.js file is found in the project root, it's loaded after all other configs so configuration can be overriden.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@svallory I believe you saw it in the AIO project. They patch Webpack configs there. |
I'm sorry but this isn't something we want to allow (extending/overriding config). You can see discussion on this topic in #1656. |
@filipesilva the discussion you are pointing to is locked! this merge request is blocked. Really? From Angular team point of view community does not has a right even to express its opinion. Angular and Google starts to SUCK! |
@ibqn This is likely coming in CLI 2.0. See design doc. |
@devoto13 it's so damn simple it's shameful it isn't implemented now. Honestly, I don't see the point. |
@svallory The problem is that if/when CLI switches to another build system instead of Webpack all projects with custom Webpack configs will get broken. This already happened when CLI replaced System.js with Webpack and I think authors don't want it to happen again. So that's why this "damn simple" feature has so "damn huge" implications :) |
@devoto13 First, I'm sorry for lashing out, I was frustrated and didn't refrain myself. I read the reason you mentioned somewhere, but I don't think that's a valid one. It's just a possible breaking change. Not that those are good, but with enough warning it's manageable. There are a lot of features for which we could say the same. And imho, I think most developers would be happy to take that risk given the huge benefit it brings. Right now the cli is all-or-nothing and it hurts to choose the "nothing" route when all I needed was, lets say, add jade templates. But my point actually is: if it's going to make into version 2, why not put it into 1.3.1? That doesn't make sense at all to me. If it's not decided yet, that's fine. But once it is it should be released ASAP instead of waiting for a major version. I want to throw away my monkey patched compiler! :) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If a webpack.config.js file is found in the project root, it's loaded after all other configs so configuration can be overriden.
I need to compile pug (jade) but didn't want to eject the cli. So I implemented this. I think I ready somewhere you guys didn't it, but I'm not sure. Please, let me know if this will make into the cli. If not, I'll publish another package.
Thanks for the hard work, guys! You are awesome, I'm loving the cli!!