Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(testing): port to Angular v4 #3524

Merged
merged 1 commit into from
Apr 12, 2017
Merged

docs(testing): port to Angular v4 #3524

merged 1 commit into from
Apr 12, 2017

Conversation

Foxandxss
Copy link
Member

@Foxandxss Foxandxss commented Apr 11, 2017 •
edited by wardbell
Loading

Repairs induced by Angular v.4

@Foxandxss Foxandxss requested a review from wardbell April 11, 2017 11:40
@wardbell
Copy link
Contributor

I fixed a few things (e.g., (done: any) to (done: DoneFn) and fixed the failing test. Force pushed.

wardbell
wardbell approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wardbell wardbell merged commit 69294a2 into angular:master Apr 12, 2017
@wardbell wardbell deleted the testing-v4 branch April 12, 2017 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wardbell wardbell wardbell approved these changes

Assignees
No one assigned
Labels
CLA: yes pr_state: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Foxandxss @wardbell @googlebot