Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$location example in developer guide needs updating #1030

Closed
rur opened this issue Jun 9, 2012 · 6 comments
Closed

$location example in developer guide needs updating #1030

rur opened this issue Jun 9, 2012 · 6 comments

Comments

@rur
Copy link

rur commented Jun 9, 2012

This example is worth updating I think, more than a little confusing the way it is:
https://github.com/angular/angular.js/blob/master/docs/content/guide/dev_guide.services.$location.ngdoc#L626

It should probably be more like this: http://jsfiddle.net/rur_d/me8AX/

@IgorMinar
Copy link
Contributor

The point of that example is to say that you can't data-bind $location directly to input-field's ngModel. Instead you have to do it the way as described.

@IgorMinar
Copy link
Contributor

your example doesn't do two-way data-binding, unless you squint a lot :)

@rur
Copy link
Author

rur commented Jun 9, 2012

It just looks like that example was left over from when this.$watch would work in the controllers.

On 9 Jun 2012, at 06:52, Igor [email protected] wrote:

The point of that example is to say that you can't data-bind $location directly to input-field's ngModel. Instead you have to do it the way as described.


Reply to this email directly or view it on GitHub:
#1030 (comment)

@IgorMinar
Copy link
Contributor

I see. I'll fix that

@IgorMinar
Copy link
Contributor

done

@rur
Copy link
Author

rur commented Jun 10, 2012

Thanks

IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Jun 11, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants