Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

bug($compile): custom annotations don't work on named controllers #14279

Closed
@petebacondarwin

Description

@petebacondarwin

BUG in angular.js : v1.5.0...v1.5.2; master
In $compile we attach custom annotations to the controller constructor. But this doesn't work if the component controller is specified by name (i.e. a controller that was defined by the module.controller(...) helper.

This was noted at #14114 (comment)

http://plnkr.co/edit/glqJw8ezAHVJAbtGY4au?p=preview

We should handle this scenario. The question is: should get hold of the referenced controller and attach the custom annotation directly to the constructor function, or whether we create a new derived controller from the named controller and assign the custom annotation to the derived controller constructor?

I thinking more likely the latter...

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions