This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix locale generation and update locales #6179
Closed
Description
After updating the google closure library locales, the locale generation fails.
The locale files then contain a reference to goog.i18n.pluralRules.get_vf_
in the pluralCat
property.
Update locale files:
i18n/update-closure.sh
i18n/generate.sh
Note: Right now no unit test if failing because of this, only jshint complains about it! We should really add unit tests for the locales as well (maybe in the i18n subfolder?).
Idea for solving this:
- add the function
goog.i18n.pluralRules.get_vf_
to every locale file, and also the functions that this function is using. - when we have a nice way for doing this, also apply this to https://github.com/angular/angular.js/blob/master/i18n/src/closureI18nExtractor.js#L90 where we replace a closure object with a custom object that we manually insert at https://github.com/angular/angular.js/blob/master/i18n/src/closureI18nExtractor.js#L164
- also extend the unit tests for
closureI18nExtractor.js
when this is implemented.