Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngClass): handle multi-class definitions as an element of an array #10651

Closed
wants to merge 1 commit into from
Closed

fix(ngClass): handle multi-class definitions as an element of an array #10651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/directive/ngClass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function classDirective(name, selector) {

function arrayClasses(classVal) {
if (isArray(classVal)) {
return classVal;
return classVal.join(' ').split(' ');
} else if (isString(classVal)) {
return classVal.split(' ');
} else if (isObject(classVal)) {
Expand Down
10 changes: 10 additions & 0 deletions test/ng/directive/ngClassSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,16 @@ describe('ngClass', function() {
}));


it('should support adding multiple classes via a space delimited string inside an array', inject(function($rootScope, $compile) {
element = $compile('<div class="existing" ng-class="[\'A B\', \'C\']"></div>')($rootScope);
$rootScope.$digest();
expect(element.hasClass('existing')).toBeTruthy();
expect(element.hasClass('A')).toBeTruthy();
expect(element.hasClass('B')).toBeTruthy();
expect(element.hasClass('C')).toBeTruthy();
}));


it('should preserve class added post compilation with pre-existing classes', inject(function($rootScope, $compile) {
element = $compile('<div class="existing" ng-class="dynClass"></div>')($rootScope);
$rootScope.dynClass = 'A';
Expand Down