This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($httpBackend): enhance readability #10852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain parts of the $httpBackend documentation there is a reoccurring description for $httpBackend methods that I thought reads a bit strange: "...function that receives the url and returns true if the url match the current definition.". This reads better as: "...function that receives a url and returns true if the url matches the current definition.".
|
Very nice patch @Yahkob - good change, good commit message - keep them coming! |
|
Thanks @pkozlowski-opensource , will do! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain parts of the $httpBackend documentation there is a recurring description for $httpBackend methods that I thought reads a bit strange:
"...function that receives the url and returns true if the url match the current definition.".
This is easier to read by changing 'the' to 'a' and 'match' to 'matches':
"...function that receives
thea url and returns true if the urlmatchmatches the current definition.".