-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(ngAnimate): Fix for toggle button #14387
Conversation
The toggle button code on line 153 only sets bool to true, rather than toggling it. The proposed change fixes this.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can you please sign the CLA? |
I've signed it On 7 April 2016 at 10:41, googlebot [email protected] wrote:
|
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Done On 7 April 2016 at 20:26, Martin Staffa [email protected] wrote:
|
The toggle button code on line 153 only sets bool to true, rather than toggling it. The proposed change fixes this. Closes #14387
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.
What is the current behavior? (You can also link to an open issue here)
Toggle button only sets value to true.
What is the new behavior (if this is a feature change)?
Toggle button toggles the value.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
The toggle button code on line 153 only sets bool to true, rather than toggling it. The proposed change fixes this.