Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngAnimate): Fix for toggle button #14387

Closed
wants to merge 1 commit into from
Closed

Conversation

glenr4
Copy link
Contributor

@glenr4 glenr4 commented Apr 7, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.

What is the current behavior? (You can also link to an open issue here)
Toggle button only sets value to true.

What is the new behavior (if this is a feature change)?
Toggle button toggles the value.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

Other information:

The toggle button code on line 153 only sets bool to true, rather than toggling it. The proposed change fixes this.

The toggle button code on line 153 only sets bool to true, rather than toggling it. The proposed change fixes this.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Narretz
Copy link
Contributor

Narretz commented Apr 7, 2016

Can you please sign the CLA?

@glenr4
Copy link
Contributor Author

glenr4 commented Apr 7, 2016

I've signed it

On 7 April 2016 at 10:41, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#14387 (comment)

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 7, 2016
@glenr4
Copy link
Contributor Author

glenr4 commented Apr 7, 2016

Done

On 7 April 2016 at 20:26, Martin Staffa [email protected] wrote:

Can you please sign the CLA?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#14387 (comment)

@Narretz Narretz self-assigned this Apr 7, 2016
@Narretz Narretz closed this in 6df1035 Apr 7, 2016
Narretz pushed a commit that referenced this pull request Apr 7, 2016
The toggle button code on line 153 only sets bool to true, rather than toggling it.
The proposed change fixes this.

Closes #14387
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants