WIP - feat($route): wait for resolves #15587
Conversation
Protractor users were having a problem where if they had asynchonous code in a route.resolve variable, Protractor was not waiting for that code to complete before continuing. See angular/protractor#789 (comment) for details Also enhanced ngMock to wait for pending requests before calling callbacks from `$browser.notifyWhenNoOutstandingRequests` Potentially breaking change if someone was relying on route.resolve not blocking `$browser.notifyWhenNoOutstandingRequests`
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
gkalpak
force-pushed
the
feat-route-wait-for-resolves
branch
2 times, most recently
from
b2bfbd9 to
8503bc3
Compare
gkalpak
force-pushed
the
feat-route-wait-for-resolves
branch
from
8503bc3 to
e7cea3d
Compare
| expect(callback).toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Needs test for resolveRedirectTo
| loadFixture('ng-route-promise'); | ||
| }); | ||
|
|
||
| it('should wait for promises in resolve blocks', function() { |
There was a problem hiding this comment.
description needs to be updated
I've just opened this one to run some tests on CI. Let's go with yours. |
Based on #14159. Just triggering CI.