This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix use of Mocha as test framework around ngMock #2073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running inside Mocha, don't look in Jasmine's spec.queue.running. It's not there. This is documented as issue angular#1467; I think this issue was also responsible for angular#1589 and recent complaints in angular#1253. Closes angular#1467.
Remove comments about angular.mock.inject and angular.mock.module being available for jasmine only. Since 1.1.1 the intent is that they be available for mocha as well; now they even work!
Change "constroctor" to "constructor".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1467 describes a real problem when trying to use the Mocha support that was introduced in 1.1.1 as pull request #1253. It seems the code actually merged for #1253 differed from the original author's proposal in one key regard.
This pull request fixes #1467, and, I believe, that's also the reason for issue #1589 and why #1253 kept attracting comments after it was closed.
While I was there, I fixed a couple comments.