chore(angular.module): improve the 'No module' error message

[bripkens]

Whether or not the 'requires' parameter of 'angular.module' is optional
depends on the state of the application. The thrown error message is
not very descriptive and can be improved. For instance, the error
could contain a hint that the parameter is required for initial
module creation.

The improvement is based on comments under the angular.module documentation.

[petebacondarwin]

I understand where you are coming from but I think that this is only a small part of the bigger API problem. For instance if you accidentally use [] twice then you get no error message at all and it quietly overwrites your previous definitions.
In the long run I think we ought to deprecate this API altogether and use something like: defineModule and updateModule to make our intention clear, where the former requires the dependencies and the latter refuses them.

Currently this fix only adds extra bytes to the build without really solving the problem. I would vote to close this for now and work towards a more comprehensive solution.

[kstep]

While I agree with @petebacondarwin about more comprehensive solution, I think @bripkens patch is good enough for now, until better solution is ready. At least newcomers will be able to understand what AngularJS wants of them for this concrete case, which is not very uncommon for beginners.

[petebacondarwin]

PR Checklist (Minor Bugfix)

• Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
• PR doesn't introduce new api
• PR doesn't contain a breaking change
• PR contains unit tests
• PR contains e2e tests (if suitable)
• PR contains documentation update (if suitable)
• PR passes all tests on Travis (sanity)
• PR passes all tests on ci.angularjs.org (cross-browser compatibility)
• PR is rebased against recent master
• PR is squashed into one commit per logical change
• PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
• All changes requested in review have been implemented

[petebacondarwin]

Hi @bripkens - can you sign the CLA?
Also we are now using minErr to generate our error messages. Can you rework this PR to use that?
Thanks

[IgorMinar]

I've reimplemented this change using the new error messaging "framework" we now use. Thanks for the suggestion.