This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(filters): close parenthesis and remove quote #3250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a missing closing parenthesis and removing unnecessary quote
| @@ -306,7 +306,7 @@ var DATE_FORMATS_SPLIT = /((?:[^yMdHhmsaZE']+)|(?:'(?:[^']|'')*')|(?:E+|y+|M+|d+ | |||
| * | |||
| * `format` string can contain literal values. These need to be quoted with single quotes (e.g. | |||
| * `"h 'in the morning'"`). In order to output single quote, use two single quotes in a sequence | |||
| * (e.g. `"h o''clock"`). | |||
| * (e.g. `"h o'clock"`). | |||
There was a problem hiding this comment.
Actually this change is incorrect. I think it should be "h 'o''clock'". Since we are "escaping" the single quote in this case.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, it makes sense. Thanks.
petebacondarwin
pushed a commit
that referenced
this pull request
Jul 17, 2013
Fix closing parenthesis, quotes around string literal and remove trailing whitespace. Closes #3250
ctrahey
pushed a commit
to ctrahey/angular.js
that referenced
this pull request
Jul 22, 2013
Fix closing parenthesis, quotes around string literal and remove trailing whitespace. Closes angular#3250
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a missing closing parenthesis and removing unnecessary quote