Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update swipe.js, in order to access in Angular controllers to complete e... #4652

Closed
wants to merge 1 commit into from

Conversation

manuelpradal
Copy link

...vent object

For example, if the angular application needs to access to pageX and pageY attributes of event object.

…e event object

For example, if the angular application needs to access to pageX and pageY attributes of event object.
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@petebacondarwin
Copy link
Contributor

Is this related to #3556 and/or #4583?

@petebacondarwin
Copy link
Contributor

@manuelpradal - can you ensure that you have signed the CLA? Thanks

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@caitp
Copy link
Contributor

caitp commented Oct 16, 2014

We're still waiting on a CLA signature here --- there's also no test case for this. I'm going to close this for now, but you're welcome to re-open with a more complete patch (with tests), and after signing the CLA.

We look forward to your future contributions =)

@caitp caitp closed this Oct 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants