Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($sniffer): IE9 backspace bug in compatibility mode #7263

Closed
wants to merge 1 commit into from

Conversation

devsoftweb
Copy link

Change IE9 input event workaround in $sniffer to
work in compatibility mode (msie can be less than 9)

Closes #3110

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7263)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@devsoftweb
Copy link
Author

The jqlite E2E test keeps failing for an unrelated reason...

Change IE9 input event workaround in $sniffer to
work in compatibility mode (msie can be less than 9)

Closes angular#3110
@cvn
Copy link

cvn commented Oct 10, 2014

Can anyone re-trigger the Travis build here? It looks like it will pass. I'd like to see this issue resolved.

@caitp
Copy link
Contributor

caitp commented Oct 10, 2014

This will be resolved by #9265 as soon as the e2e test is ready to land

@caitp
Copy link
Contributor

caitp commented Oct 10, 2014

(which will hopefully be monday)

@caitp caitp closed this Oct 10, 2014
@devsoftweb
Copy link
Author

#9265 will fix this, but it's in the 1.3 branch. Is it possible to back-merge this (smaller) fix into the 1.2 branch?

@caitp
Copy link
Contributor

caitp commented Oct 15, 2014

It may be possible

@caitp
Copy link
Contributor

caitp commented Oct 15, 2014

I believe the original attempt at fixing the dumb IE bug wound up in v1.2.x

@devsoftweb
Copy link
Author

Fix wasn't in v1.2.x, so I opened #9917

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE9 Backspace bug in compatibility mode
6 participants