Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(bootstrap): remove an unused argument #7649

Closed
wants to merge 1 commit into from

Conversation

pomerantsev
Copy link
Contributor

$animate not used in this function anymore.

$animate not used in this function anymore.
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7649)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@caitp
Copy link
Contributor

caitp commented May 31, 2014

I don't think this is correct (although I could be wrong, @matsko would know this code better than me).

It looks like ngAnimate.$animate needs to do some work on startup, even though the undecorated version doesn't. I think we need this injected here so that $rootElement gets touched early --- although work done during $compile might make this unnecessary

@pomerantsev
Copy link
Contributor Author

Great. I'd love to know for sure if this is wrong. Looks like a leftover - $animate was used here previosly, but it was removed at some point.

@matsko
Copy link
Contributor

matsko commented Jun 2, 2014

Merged. Thank you @pomerantsev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants