Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

@derrickmar
Copy link
Contributor

The purpose of adding the image attribute is so that one of the tests in controllerSpecs.js does not fail in step_10.ngdoc when we add $scope.mainImageUrl = data.images[0]; to PhoneDetailCtrl.

The purpose of adding the image attribute is so controllerSpecs.js does not break in step_10.ngdoc when we add $scope.mainImageUrl = data.images[0]; to PhoneDetailCtrl.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

Make image attribute an array that is consistent with step_11.ngdoc
@derrickmar
Copy link
Contributor Author

Hi Mary. Apologies, should have read the Contributing.md first. I submitted a form for CLA.

@petebacondarwin
Copy link
Contributor

This change to the test actually occurs in step-10. See angular/angular-phonecat@5f6c5df#diff-4
So it would make sense to update that step in the tutorial instead.
Do you think you could create a new PR with a change that matches the diff above?

@derrickmar
Copy link
Contributor Author

Sure I'll go ahead and do that.

derrickmar added a commit to derrickmar/angular.js that referenced this pull request Aug 8, 2014
petebacondarwin pushed a commit that referenced this pull request Aug 8, 2014
petebacondarwin pushed a commit that referenced this pull request Aug 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants