-
Notifications
You must be signed in to change notification settings - Fork 26.7k
Fix Docs for Modules and Refactor @publicModule tag to @exportedAs
#1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/angular2/change_detection.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the rename? I think publicModule is a better name. Can you share your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be exportedAs
|
Rename |
|
The reason for the rename is that it no longer puts the onus on the exported component to tell that the module is public. This is also considerably more flexible as it allows modules that only contain direct exports and not reexports to be public. Also it allows items to be decl |
|
Phone finger slippage... Also it allows components to be reexported internally too for the private docs |
|
Regarding the naming... The tag is attached to a component that is an export on a private module. The tag declares that this component is also exported from another module. Exported as implies that a module is being aliased, which is not accurate. But if you are sure you want it that way then I can change it. |
|
I think |
The template was referencing an invalid property
…odule` This commit refactors how we describe components that are re-exported in another module. For example the "public" modules like `angular/angular` and `angular/annotations` are public but they only re-export components from "private" modules. Previously, you must apply the `@publicModule` tag to a component that was to be re-exported. Applying this tag caused the destination module to become public. Now, you specify that a module is public by applying the `@public` tag and then you can "re-export" components to other modules by applying the `@exportedAs` giving the name of the module from which the component will be re-exported. tag. This tag can be used multiple times on a single component, allowing the component to be exported on multiple modules.
The `@publicModule` dgeni tag has been replaced by the `@exportedAs` dgeni tag on components that are to be re-exported on another module.
@publicModule tag to @exportedFrom@publicModule tag to @exportedAs
|
@mhevery - updated with |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@naomiblack and @mhevery
@moduletag to indicate that it documents the module rather than code components exported from the module. Also you now specify that a module is or public consumption by applying the@publictag on the module itself. For example:The other major change in this PR is that the
@publicModuletag has been replaced with the@exportedAstag, which can be applied multiple times to a single code component. What this implies is that the associated code component has also been exported on other modules.Closes #1258