Skip to content

Conversation

@jeffbcross
Copy link
Contributor

TODO:

  • Add documentation comments
  • Open issues to capture remaining features for current milestone

This implementation only works in JavaScript, while the Observable transpilation
story gets worked out. Right now, the service just makes a simple request,
and returns an Observable of Response.

Fixes #2028

@jeffbcross jeffbcross added this to the M10 milestone Jun 5, 2015
@jeffbcross jeffbcross added feature Issue that requests a new feature comp: data-access labels Jun 5, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pattern seems to be httpInjectables
https://github.com/angular/angular/blob/master/modules/angular2/router.ts#L33
https://github.com/angular/angular/blob/master/modules/angular2/router.ts#L33

could you also export Http, HttpFactory, XHRBackend, and BrowserXHR for users who want to overwrite/replace/remake etc

@jeffbcross
Copy link
Contributor Author

Thanks for all the comments, @gdi2290!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove args for symmetry

@jeffbcross
Copy link
Contributor Author

@vsavkin did you have any other feedback other than what we captured on our call? (If not, can you add lgtm label?)

@vsavkin
Copy link
Contributor

vsavkin commented Jun 8, 2015

@jeffbcross no, just make Travis happy!

@vsavkin vsavkin added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: discuss labels Jun 8, 2015
This implementation only works in JavaScript, while the Observable transpilation
story gets worked out. Right now, the service just makes a simple request,
and returns an Observable of Response.

Additional functionality will be captured in separate issues.

Fixes angular#2028
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 9, 2015
@jeffbcross jeffbcross added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 9, 2015
@jeffbcross
Copy link
Contributor Author

Merged at 2156810

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: no feature Issue that requests a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

land basic http lib

5 participants