Skip to content

Conversation

@pkozlowski-opensource
Copy link
Member

I wasn't sure if we've got some mechanism in place to avoiding matching all the directives specified in the @View annotation, so add a test. We might easily get into duplicate directives situation, as soon as we start to include coreDirectives in the @View by default.

Not sure if this test is mandatory, but I couldn't find the place where we filter out duplicates....

Review on Reviewable

@tbosch
Copy link
Contributor

tbosch commented Jun 18, 2015

Please rebase

@tbosch tbosch added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Jun 18, 2015
@pkozlowski-opensource
Copy link
Member Author

@tbosch I've rebased this one but now, after the rebase, it looks like the tested use-case doesn't work any more - that is - the test discovers a real bug! I will take a look at the underlying cause.

@tbosch
Copy link
Contributor

tbosch commented Jun 29, 2015

@pkozlowski-opensource Could you investigate a little more why this is a problem?

@tbosch tbosch added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 29, 2015
@pkozlowski-opensource
Copy link
Member Author

@tbosch I'm afraid I will need some input from you on this one, see #2756 (comment)

Will ping you later today.

@pkozlowski-opensource
Copy link
Member Author

@tbosch rebased and fixed code to remove duplicate directives as discussed yesterday. We are applying very similar logic to the one in the injector

PTAL

BTW, build is failing due to the NPM install issues, nothing to do with this PR...

@pkozlowski-opensource pkozlowski-opensource removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 1, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add one more test (just for a future reader) that states: 'It should use the last directive binding per directive'?

@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 1, 2015
@pkozlowski-opensource
Copy link
Member Author

@tbosch added a test. Is there anything else I should add or is this one good to go?

@pkozlowski-opensource pkozlowski-opensource removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 1, 2015
@tbosch
Copy link
Contributor

tbosch commented Jul 1, 2015

Please merge!

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Jul 1, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants